Skip to content

Conversation

@StyleTang
Copy link
Member

What is the purpose of the change

Send test message with message trace

Brief changelog

User can choose send test message with message trace or not.

Verifying this change

Send test message with trace on.

image

Message Trace

image

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@weibubli
Copy link

weibubli commented Aug 4, 2021

LGTM

@vongosling
Copy link
Member

@StyleTang Could you help to check again, the code has a conflict with the latest update for SSL:-)

@StyleTang StyleTang force-pushed the send-trace-message branch from 7b30af9 to d2cd75b Compare August 5, 2021 13:52
@StyleTang
Copy link
Member Author

Conflict resolved.

@zhangjidi2016
Copy link
Contributor

LGTM

@vongosling
Copy link
Member

There are too many errors in our unit test, I think this is a very good contribution spot, looking forward to your attention here :-) @weibubli @zhangjidi2016 @StyleTang

@vongosling vongosling linked an issue Aug 6, 2021 that may be closed by this pull request
@vongosling vongosling merged commit 01184a1 into apache:master Aug 6, 2021
@zhangjidi2016
Copy link
Contributor

Most of the errors were thrown by the previous XxxServiceImpl unit test, and the execution time was very long, I think we can delete this section, the submitted controller unit test has basically covered XxxServiceImpl in the execution.
This is the unit test time I executed after I removed xxxServiceImplTest and the overall project code coverage.

image
image

@vongosling
Copy link
Member

@zhangjidi2016 cool, I like what you said. could you pr it and I'd like to help to check it again?

@zhangjidi2016
Copy link
Contributor

zhangjidi2016 commented Aug 6, 2021

@zhangjidi2016 cool, I like what you said. could you pr it and I'd like to help to check it again?

https://github.com/apache/rocketmq-externals/pull/663 @vongosling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RocketMQ Console] Send message with message trace

5 participants