Proxy gRPC metric settings should tolerate invalid collector address

[Aias00]

Problem

GrpcClientSettingsManager.mergeMetric(...) parses the configured metric collector address with a raw split:

String[] split = metricCollectorAddress.split(":");
String host = split[0];
int port = Integer.parseInt(split[1]);

When metricCollectorMode=on but metricCollectorAddress is blank or malformed, the settings merge path can throw ArrayIndexOutOfBoundsException or NumberFormatException. That can break gRPC client settings generation instead of returning a controlled metric setting.

Expected behavior

Proxy should not fail client settings merge because of an invalid optional metric collector address. It should validate the address, log a clear warning, and disable metric collection for that settings response when the address cannot be parsed.

Scope

Track 2 / Proxy gRPC client diagnostics and robustness. This only hardens metric endpoint parsing in gRPC client settings and should not change valid host:port handling.

Evidence

• proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/common/GrpcClientSettingsManager.java
• mergeMetric(...) reads metricCollectorAddress.split(":") and indexes split[1] without validation.

[RockteMQ-AI]

Issue Evaluation

Category: type/bug | Status: Confirmed

The reported issue has been verified against the current codebase (develop@eddb235c1bd8).

Root Cause: GrpcClientSettingsManager.mergeMetric(...) calls metricCollectorAddress.split(":") and directly indexes split[1] without validating that the address is non-blank or contains a colon. When metricCollectorMode=ON and the address is blank or malformed, this throws ArrayIndexOutOfBoundsException or NumberFormatException.

Impact: gRPC client settings generation fails entirely when metric collector address is misconfigured, instead of gracefully degrading.

Severity: medium — requires misconfiguration to trigger, but the failure is uncontrolled.

File: proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/common/GrpcClientSettingsManager.java (lines 120-122)

An automated fix proposal will be generated. Reply /approve to proceed with PR generation.

---

Automated evaluation by github-manager-bot