[Bug] BrokerIdentityInfo.equals throws for partial identities

[yuluo-yx]

Before Creating the Bug Report

• I found a bug, not just a question.
• I searched open GitHub Issues and pull requests and found no duplicate.
• I confirmed that this bug belongs to Apache RocketMQ.

Runtime platform environment

macOS (Darwin), reproduced with an isolated local unit test.

RocketMQ version

Branch: develop
Git commit: fd0c959

JDK Version

Zulu OpenJDK 8 (8.94.0.17)

Describe the Bug

BrokerIdentityInfo supports partial identities: RaftReplicasInfoManager creates instances with null clusterName and brokerId. However, equals calls equals directly on every field, so comparing two valid partial identities throws NullPointerException. hashCode is already null-safe.

Steps to Reproduce

1. Create two BrokerIdentityInfo instances with null clusterName, brokerName set, and null brokerId.
2. Call equals between them.
3. Observe NullPointerException.

What Did You Expect to See?

Two equivalent partial identities should compare equal and remain consistent with hashCode.

What Did You See Instead?

equals dereferences nullable fields and throws NullPointerException.

Additional Context

Complete identities, partial identities, and differing fields can all be covered with a small unit test.

[RockteMQ-AI]

Issue Evaluation

Category: type/bug | Status: Confirmed

Root Cause: BrokerIdentityInfo.equals does not handle partial identity fields (some null, some set). When comparing two instances where one has partial fields, it throws NullPointerException.
Impact: Broker identity comparison — cluster membership checks may crash when broker identity information is incomplete during startup or configuration changes.
Severity: medium

---

Automated evaluation by github-manager-bot

[RockteMQ-AI]

Issue Evaluation

Category: bug | Status: Confirmed

The reported issue has been verified against the current codebase.

Root Cause: BrokerIdentityInfo.equals does not handle partial identity objects gracefully. When some identity fields are null or unset, the equality check throws a NullPointerException instead of returning false.

Impact: Broker identity comparison crashes when brokers have incomplete identity information, potentially affecting broker registration, cluster topology detection, and failover logic.

Severity: Medium — can cause unexpected crashes in broker identity comparison paths.

An automated fix proposal can be generated. Reply /approve to proceed with PR generation.

---

Automated evaluation by RockteMQ-AI