Skip to content

[ISSUE #10225] Check expired receipt handle locks before blocking - #10664

Closed
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/receipt-handle-expired-lock
Closed

[ISSUE #10225] Check expired receipt handle locks before blocking#10664
Aias00 wants to merge 1 commit into
apache:developfrom
Aias00:fix/receipt-handle-expired-lock

Conversation

@Aias00

@Aias00 Aias00 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • check ReceiptHandleGroup.HandleData expired locks before entering the blocking semaphore wait
  • keep the existing blocking fallback for non-expired locks
  • add coverage that an expired lock is reacquired without waiting for the full caller timeout

Tests

  • mvn -pl proxy -Dtest=ReceiptHandleGroupTest test
  • git diff --check

Fixes #10225

Copilot AI review requested due to automatic review settings July 26, 2026 07:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Closing this because #10225 is already covered by the existing open PR #10226. I missed that PR in the earlier narrower search and do not want to duplicate the review queue.

@Aias00 Aias00 closed this Jul 26, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.22%. Comparing base (d8c3f9e) to head (53f6fb6).

Files with missing lines Patch % Lines
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 76.19% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10664      +/-   ##
=============================================
- Coverage      48.32%   48.22%   -0.11%     
+ Complexity     13511    13476      -35     
=============================================
  Files           1380     1380              
  Lines         101091   101101      +10     
  Branches       13101    13103       +2     
=============================================
- Hits           48852    48751     -101     
- Misses         46278    46367      +89     
- Partials        5961     5983      +22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throughput of in-flight message renewal degrades while some handle data locks have expired

3 participants