[ISSUE #10806] Log proxy remoting cleanup failures - #10807
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Proxy remoting expired-request queue cleanup to avoid silently swallowing unexpected failures by logging a warning with compact queue context and breaking out of the current cleanup pass. It also adds a regression test to ensure the cleanup does not spin when queue access fails.
Changes:
- Log unexpected exceptions during
cleanExpiredRequestInQueuewith queue size context and stop the current cleanup pass. - Add
safeQueueSize(...)helper to safely obtain queue size for logging. - Add a regression unit test covering queue access failure behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
proxy/src/main/java/org/apache/rocketmq/proxy/remoting/RemotingProtocolServer.java |
Logs cleanup failures with queue context and breaks the cleanup loop to prevent silent churn. |
proxy/src/test/java/org/apache/rocketmq/proxy/remoting/RemotingProtocolServerTest.java |
Adds regression coverage ensuring cleanup stops promptly when getQueue() throws. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10807 +/- ##
=============================================
- Coverage 48.33% 48.23% -0.10%
+ Complexity 13524 13488 -36
=============================================
Files 1380 1380
Lines 101104 101113 +9
Branches 13107 13108 +1
=============================================
- Hits 48864 48772 -92
- Misses 46281 46355 +74
- Partials 5959 5986 +27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Tests
Closes #10806