[ISSUE #11011] Fix misplaced license header in ConfigManagerTest - #11012
Merged
Conversation
Move the ASF license comment to the top of the file, before the package statement. It was squeezed onto the same line as the package declaration (introduced by b6ff649), which breaks the conventional header placement used across the codebase.
RongtongJin
approved these changes
Sep 4, 2026
RockteMQ-AI
approved these changes
Sep 4, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Trivial formatting fix — moves the ASF license header back to its canonical position above the package declaration. No behavioral change.
Automated review by "github-manager-bot"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11012 +/- ##
=============================================
- Coverage 48.80% 48.74% -0.06%
+ Complexity 13768 13748 -20
=============================================
Files 1381 1381
Lines 101574 101574
Branches 13213 13213
=============================================
- Hits 49571 49515 -56
- Misses 45971 46017 +46
- Partials 6032 6042 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
In
common/src/test/java/org/apache/rocketmq/common/ConfigManagerTest.java, the ASF license header was squeezed onto the same line right after thepackagestatement, instead of sitting at the top of the file. This was introduced by b6ff649 ("feat(all):new feature for static topic"), likely by an auto-formatter.This PR moves the license comment back to the top of the file, before the
packagedeclaration, matching the canonical header placement used across the codebase. The resulting header is byte-identical to the standard ASF header already used by the other ~2000 files in the repository.How Did You Test This Change?
Formatting-only change with no behavioral impact. Verified the relocated header block is byte-identical to the canonical ASF header used by the rest of the codebase (the change only moves the comment above the
packageline and adds a newline), and that the file structure (package -> blank line -> imports) is preserved.