[Bug] Return null when broker address table is unavailable - #11031
Open
zjncs wants to merge 1 commit into
Open
Conversation
Signed-off-by: zjncs <18910855655@163.com>
zjncs
marked this pull request as ready for review
September 5, 2026 09:29
RockteMQ-AI
approved these changes
Sep 5, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Summary
Good defensive fix — adds null/empty check to selectBrokerAddr() to prevent NPE when broker address table is unavailable. Returns null gracefully instead of throwing.
The test validates both null and empty map cases.
LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10873
BrokerData.selectBrokerAddr now returns null when brokerAddrs is null or empty, instead of throwing NullPointerException or IllegalArgumentException from Random.nextInt(0). Master preference and random slave fallback remain unchanged.
Added regression coverage for both null and empty tables.
Verification: git diff --check passed; Maven unavailable locally, CI should run BrokerDataTest/remoting checks. AI-assisted contribution.