Skip to content

IncHashSlotCount fix#1713

Closed
zhhlovely wants to merge 3 commits intoapache:masterfrom
zhhlovely:incHashSlotCountFix
Closed

IncHashSlotCount fix#1713
zhhlovely wants to merge 3 commits intoapache:masterfrom
zhhlovely:incHashSlotCountFix

Conversation

@zhhlovely
Copy link
Copy Markdown
Contributor

What is the purpose of the change

修复索引槽位已使用统计问题,IncHashSlotCount的增加应该是判断这个槽位为空的时候才应该进行+1操作,如果查询发现不为空,即代表之前这个槽之前已经被占领了,就不应该进行IncHashSlotCount增加操作。

Brief changelog

IndexFile putKey(final String key, final long phyOffset, final long storeTimestamp) 进行了修改
XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@xujianhai666
Copy link
Copy Markdown
Member

@zhhlovely ci err, fix firstly. Besides, I thought the hashSlot is the number of slot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants