Skip to content

IncHashSlotCount fix #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhhlovely wants to merge 3 commits into from
Closed

IncHashSlotCount fix #1713

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c17b802
Merge pull request #1 from apache/master
zhhlovely Oct 10, 2019
8fcd625
Merge pull request #2 from apache/master
zhhlovely Jan 10, 2020
ffdbf75
fix incHashSlotCount
zhhlovely Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions store/src/main/java/org/apache/rocketmq/store/index/IndexFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,10 @@ public boolean putKey(final String key, final long phyOffset, final long storeTi
// fileLock = this.fileChannel.lock(absSlotPos, hashSlotSize,
// false);
int slotValue = this.mappedByteBuffer.getInt(absSlotPos);
boolean incHashSlotCount=false;
if (slotValue <= invalidIndex || slotValue > this.indexHeader.getIndexCount()) {
slotValue = invalidIndex;
incHashSlotCount=true;
}

long timeDiff = storeTimestamp - this.indexHeader.getBeginTimestamp();
Expand Down Expand Up @@ -133,8 +135,9 @@ public boolean putKey(final String key, final long phyOffset, final long storeTi
this.indexHeader.setBeginPhyOffset(phyOffset);
this.indexHeader.setBeginTimestamp(storeTimestamp);
}

this.indexHeader.incHashSlotCount();
if (incHashSlotCount) {
this.indexHeader.incHashSlotCount();
}
this.indexHeader.incIndexCount();
this.indexHeader.setEndPhyOffset(phyOffset);
this.indexHeader.setEndTimestamp(storeTimestamp);
Expand Down