Skip to content

Conversation

@Oliverwqcwrw
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

fix the spelling error

Brief changelog

Message lock,strictly ensure the single queue only one thread at a time consuming should be Message lock,strictly ensure the single queue only one thread at a time-consuming

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Contributor

@Kvicii Kvicii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original comment means 'ensure the single queue can be consumed by one thread'. Also, 'time-consuming' is an adjective and inappropriate to be used in this way.

@Oliverwqcwrw
Copy link
Member Author

I don't think it changed the original meaning, just optimize the spelling

@codecov-commenter
Copy link

Codecov Report

Merging #4014 (cab3872) into develop (03c5a3d) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4014      +/-   ##
=============================================
- Coverage      47.95%   47.71%   -0.24%     
+ Complexity      5004     4969      -35     
=============================================
  Files            633      633              
  Lines          42520    42528       +8     
  Branches        5571     5573       +2     
=============================================
- Hits           20391    20293      -98     
- Misses         19633    19730      +97     
- Partials        2496     2505       +9     
Impacted Files Coverage Δ
...ocketmq/client/impl/consumer/MessageQueueLock.java 77.77% <ø> (ø)
.../main/java/org/apache/rocketmq/common/UtilAll.java 42.23% <0.00%> (ø)
...rocketmq/broker/filtersrv/FilterServerManager.java 20.00% <0.00%> (-14.29%) ⬇️
.../org/apache/rocketmq/store/PutMessageSpinLock.java 85.71% <0.00%> (-14.29%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (-5.56%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...apache/rocketmq/remoting/netty/ResponseFuture.java 85.00% <0.00%> (-5.00%) ⬇️
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...rocketmq/remoting/netty/NettyRemotingAbstract.java 46.88% <0.00%> (-4.03%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c5a3d...cab3872. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 51.778% when pulling cab3872 on Oliverwqcwrw:develop into 6ff00ed on apache:develop.

@coveralls
Copy link

coveralls commented Mar 22, 2022

Coverage Status

Coverage increased (+0.05%) to 51.912% when pulling ab7f7ee on Oliverwqcwrw:develop into 6ff00ed on apache:develop.

@Oliverwqcwrw Oliverwqcwrw changed the title fix the spelling error [ISSUE #4021]fix the spelling error Mar 22, 2022
@Oliverwqcwrw
Copy link
Member Author

PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants