-
Notifications
You must be signed in to change notification settings - Fork 12k
[ISSUE #4021]fix the spelling error #4014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kvicii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caigy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original comment means 'ensure the single queue can be consumed by one thread'. Also, 'time-consuming' is an adjective and inappropriate to be used in this way.
|
I don't think it changed the original meaning, just optimize the spelling |
Codecov Report
@@ Coverage Diff @@
## develop #4014 +/- ##
=============================================
- Coverage 47.95% 47.71% -0.24%
+ Complexity 5004 4969 -35
=============================================
Files 633 633
Lines 42520 42528 +8
Branches 5571 5573 +2
=============================================
- Hits 20391 20293 -98
- Misses 19633 19730 +97
- Partials 2496 2505 +9
Continue to review full report at Codecov.
|
|
PTAL |
Make sure set the target branch to
developWhat is the purpose of the change
fix the spelling error
Brief changelog
Message lock,strictly ensure the single queue only one thread at a time consumingshould beMessage lock,strictly ensure the single queue only one thread at a time-consumingVerifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.