Skip to content

Conversation

@123liuziming
Copy link
Contributor

@123liuziming 123liuziming commented May 12, 2022

Make sure set the target branch to develop

What is the purpose of the change

Add protocols to readme and delete the description of language clients

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

vongosling and others added 2 commits December 10, 2021 17:30
Depracated MODERATE noisy mail for dev@rocketmq.apache.org. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever
@duhenglucky duhenglucky changed the base branch from master to develop May 13, 2022 02:12
@duhenglucky duhenglucky merged commit 5610630 into apache:develop May 13, 2022
@duhenglucky duhenglucky added this to the 4.9.4 milestone May 13, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…n of language clients (apache#4285)

* Update .travis.yml

Depracated MODERATE noisy mail for dev@rocketmq.apache.org. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever

* Update README.md

Co-authored-by: von gosling <vongosling@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants