Conversation
[RIP 30] Support Compaction topic
* replicate from master * fix unit test * fix unit test * LogAndCq * combine log and CQ * replace file * clean after replicating * unit test * bug fix * dump command * compaction cycle and dump log tool * fix the first compaction not trigger * optimize stop pull logic * fix checkstyle * replaces error when compact replicating and current * force clean cq in replicating * force clean cq in replicating * mapped file queue empty judgement fix * clean compacting folder * validate cqUnit when getMessage * clear files when replace completed * optimize sparse consume queue recover * disable allocate mapped file & separate compaction load and start * code optimize * fix compaction error * checkstyle * checkstyle * compactionLog size base on sparse consume queue size * bugfix * fix * fix unit test
Contributor
|
It's a huge pull request and massive modifications to critical parts. It would be good to split it into multiple smaller ones so we can have quality reviews. The open-close principle should be seriously considered after a quick review of the change. |
lizhanhui
requested changes
Sep 9, 2022
Contributor
lizhanhui
left a comment
lizhanhui
left a comment
There was a problem hiding this comment.
Split into smaller prs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.