Skip to content

[ISSUE #8046] Fix authentication context build for no extFields#8047

Closed
dingshuangxi888 wants to merge 13 commits intoapache:developfrom
dingshuangxi888:develop
Closed

[ISSUE #8046] Fix authentication context build for no extFields#8047
dingshuangxi888 wants to merge 13 commits intoapache:developfrom
dingshuangxi888:develop

Conversation

@dingshuangxi888
Copy link
Contributor

@dingshuangxi888 dingshuangxi888 commented Apr 22, 2024 •
edited
Loading

Which Issue(s) This PR Fixes

Fixes #8046

Brief Description

Fix authentication context build for no extFields

How Did You Test This Change?

start producer/consumer without ak/sk

@lizhimins lizhimins changed the title [ISSUE #8046]Fix authentication context build for no extFields [ISSUE #8046] Fix authentication context build for no extFields Apr 22, 2024
caigy
caigy previously approved these changes Apr 25, 2024
View reviewed changes
LittleBoy18 and others added 11 commits May 7, 2024 11:17
@LittleBoy18 @dingshuangxi888
[ISSUE #8032] Set checkDupInfo value from config
5c24b59
@syshenyao @dingshuangxi888
[ISSUE#6398] Remove duplicate code in TopicPublishInfo (#8034)
8b31dfa 
Co-authored-by: yao.shen@hstong.com <yao.shen@hstong.com>
@RongtongJin @dingshuangxi888
Add expression filtering capability to the pullBlockIfNotFound method…
0d79e45 
… of pull consumer (#8024)
@redlsz @dingshuangxi888
[ISSUE #7909] Fix send retry message permission check (#7917)
44e37b0
@mxsm @dingshuangxi888
[ISSUE #8044]Add Override annotation for AllocateMappedFileService#run (
944fe8c 
#8045)
@HScarb @dingshuangxi888
[ISSUE #8075] Fix workflow and skip failed test for auth module on mac (
5e8c583 
#8068)

* build: fix coverage workflow

* Skipping some tests under the auth package on Mac

* build: fix test imports
@redlsz @dingshuangxi888
Fix exception when pop messages with multiple LMQ indexes (#7863)
bc6ec71
@RongtongJin @dingshuangxi888
[ISSUE #8095] Fix some flaky tests on Mac's workflow (#8083)
f84a087
@HScarb @dingshuangxi888
[ISSUE #8096] fix log placeholder
9ec7cff
@lizhimins @dingshuangxi888
[ISSUE #8076] Fix correct min cq offset when delete tiered storage Co…
3d8c0db 
…mmitLog (#8082)
@redlsz @dingshuangxi888
[ISSUE #8098] Fix parsing delay message type from property
190bf00
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 49.18033% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 42.83%. Comparing base (b39f65e) to head (190bf00).
Report is 13 commits behind head on develop.

Files Patch % Lines
...lient/impl/consumer/DefaultMQPullConsumerImpl.java 0.00% 6 Missing ⚠️
...mq/client/impl/producer/DefaultMQProducerImpl.java 0.00% 4 Missing ⚠️
...ocketmq/client/consumer/DefaultMQPullConsumer.java 0.00% 3 Missing ⚠️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 82.35% 2 Missing and 1 partial ⚠️
...n/builder/DefaultAuthenticationContextBuilder.java 0.00% 1 Missing and 1 partial ⚠️
...on/builder/DefaultAuthorizationContextBuilder.java 0.00% 1 Missing and 1 partial ⚠️
...pl/consumer/ConsumeMessageConcurrentlyService.java 0.00% 2 Missing ⚠️
.../apache/rocketmq/common/stats/MomentStatsItem.java 0.00% 2 Missing ⚠️
.../rocketmq/client/impl/ClientRemotingProcessor.java 0.00% 1 Missing ⚠️
...nt/impl/consumer/ConsumeMessageOrderlyService.java 50.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #8047      +/-   ##
=============================================
- Coverage      42.88%   42.83%   -0.05%     
- Complexity     10348    10353       +5     
=============================================
  Files           1270     1270              
  Lines          88673    88692      +19     
  Branches       11398    11400       +2     
=============================================
- Hits           38029    37993      -36     
- Misses         45950    46004      +54     
- Partials        4694     4695       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caigy caigy caigy left review comments

+1 more reviewer

@humkum humkum humkum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Fix authentication context build for no extFields