Add release notes and stop shipping third-party jars in the source release - #179
Merged
Conversation
…lease The source distribution carried four third-party jars under docs/examples/scripting: bsf.jar, roller-rap-sdk.jar, commons-codec-1.3.jar and jdom.jar. A source release should carry source, and none of the four were accounted for in LICENSE or NOTICE. The examples' README files now say to obtain them separately. Also adds CHANGES.md, which the release announcement and vote can point at. It starts at 6.1.6; earlier notes stay in the mailing list archive. Claude-Session: https://claude.ai/code/session_019R1jdtwkaYEeA6L9DXEtEi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pieces of release preparation.
Third-party jars removed from the source distribution
The source release carried four compiled third-party jars under
docs/examples/scripting/:bsf/lib/bsf.jargroovy/examples/adminprotocol/lib/roller-rap-sdk.jargroovy/examples/adminprotocol/lib/commons-codec-1.3.jargroovy/examples/adminprotocol/lib/jdom.jarA source release should carry source. None of the four appear in
LICENSEorNOTICE, so they were also unaccounted for, andcommons-codec-1.3andbsf.jarare old enough that nobody currently active chose them.The two README files that told readers to use these jars now say to obtain them separately; the classpath examples are otherwise unchanged. Nothing in the build referenced them — the assembly descriptor takes
docs/wholesale rather than naming them.After this change
docs/contains no.jar,.waror.classfiles at all.CHANGES.md
There was no release notes file in the repo, so the vote and announcement had nothing to point at. This adds one, starting at 6.1.6; earlier notes stay in the mailing list archive.
It leads with the three retirements that need action before upgrading — incoming Trackback, outbound Trackback, and WSSE AtomPub authentication, the last of which now fails closed on startup rather than falling back — followed by the media content type and enclosure metadata behaviour changes, then the rest.
Verification
Full suite on JDK 11: 297 tests, 0 failures, 0 errors, 1 skipped.
https://claude.ai/code/session_019R1jdtwkaYEeA6L9DXEtEi