SAMZA-2447: Checkpoint dir removal should only search in valid store dirs - #1261
Merged
Conversation
prateekm
reviewed
Jan 28, 2020
| } | ||
|
|
||
| @Test | ||
| public void testRemoveOldCheckpoints() { |
Contributor
There was a problem hiding this comment.
Looks like this is testing the specific sub-case when listFiles returns null. If so, let's rename method to reflect that (e.g. testRemoveOldCheckpointsWhenXYZ
prateekm
approved these changes
Jan 28, 2020
prateekm
left a comment
prateekm
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom: NPE when attempting to remove old checkpoint directories.
Cause: Removal of old checkpoints assumes every file in the logged store base directory is also a directory, which may not be true if the user has configured it to a path that is not exclusive to store contents.
Changes: Check that the result of
listFilesis non-null before attempting to delete.Tests: Wrote a test to mimic the behavior of a non-directory file in the logged store base directory. Test fails without the patch, passes with it.
API Changes: None
Upgrade Instructions: None
Usage Instructions: None