SAMZA-2525:Fix race condition in ClientHelper#isActiveApplication#1361
Merged
Conversation
Symptom:Incorrect job status reported, which is previous deployed job status instead of current job. Cause:ClientHelper#isActiveApplication is invoking toAppStatus twice when comparing status to Running or New. It could happen that 1st time, the status is New which failed Running check, and 2nd invocation returns Running, which failed New check, this will result in the current app to be classified as non active causing ClientHelper to return job status of a previous deployed app. Changes: Update ClientHelper#isActiveApplication to invoke toAppStatus once and compare both status against this single result. Tests: None API Changes: None Upgrade Instructions: None Usage Instructions: None
lakshmi-manasa-g
approved these changes
May 15, 2020
cameronlee314
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom:Incorrect job status reported, which is previous deployed job status instead of current job.
Cause:ClientHelper#isActiveApplication is invoking toAppStatus twice when comparing status to Running or New. It could happen that 1st time, the status is New which failed Running check, and 2nd invocation returns Running, which failed New check, this will result in the current app to be classified as non active causing ClientHelper to return job status of a previous deployed app.
Changes: Update ClientHelper#isActiveApplication to invoke toAppStatus once and compare both status against this single result.
Tests: None
API Changes: None
Upgrade Instructions: None
Usage Instructions: None