Skip to content

SAMZA-1408 update master doc to use 0.14.0-SNAPSHOT after 0.13.1 release - #285

Closed
fredji97 wants to merge 2 commits into
apache:masterfrom
fredji97:master_doc
Closed

SAMZA-1408 update master doc to use 0.14.0-SNAPSHOT after 0.13.1 release#285
fredji97 wants to merge 2 commits into
apache:masterfrom
fredji97:master_doc

Conversation

@fredji97

Copy link
Copy Markdown

No description provided.

Comment thread docs/archive/index.html Outdated
<h4 id="13.1">0.13.1 Release</h4>

<ul class="documentation-list">
<li><a href="../learn/documentation/0.13.1">Documentation</a></li>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and who will be creating these docs? Are they created automatically?

@nickpan47 nickpan47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check docs/learn/tutorials/versioned/samza-rest-getting-started.md as well. We can leave docs/startup/preview/index.md as is for now, since that should be fixed as part of documentation work in 0.14.

Comment thread docs/_config.yml Outdated
version: latest
# this is the version you will go if you click 'switch version' in "latest" pages.
latest-release: '0.13'
latest-release: '0.13.1'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change this. We only track major versions in doc site (i.e. 0.13.1 doc will over write 0.13 version doc, not creating a new 0.13.1 version doc site).

Comment thread docs/_layouts/default.html Outdated
<h1><i class="fa fa-history"></i> Archive</h1>
<ul>
<li><a href="/archive/index.html#latest">latest</a></li>
<li><a href="/archive/index.html#13.1">0.13.1</a></li>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this.

Comment thread docs/archive/index.html Outdated
<li><a href="../startup/hello-samza/latest">Hello Samza</a></li>
</ul>

<h4 id="13.1">0.13.1 Release</h4>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Since we are simply over writing 0.13 doc sites, no need to create new versioned doc site links here.

@fredji97

Copy link
Copy Markdown
Author

PR updated based on the comments. @nickpan47 please take another look, thanks!

@nickpan47 nickpan47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. 👍

@asfgit asfgit closed this in 3a13438 Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants