[Chore]Restore SeaTunnelEngineLocalExample#11073
Merged
Merged
Conversation
DanielLeens
reviewed
Jun 12, 2026
DanielLeens
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution. I reviewed the current diff against the refreshed dev baseline and traced the startup path of SeaTunnelEngineLocalExample.
What This PR Solves
- User pain: the current local engine example points to stain-trace resources that are no longer present in the example resources, so the default example path is broken out of the box.
- Fix approach: restore the local example to the normal fake_to_console example config and remove the hard-wired stain-trace seatunnel.config override.
- One-line summary: the code-side fix is straightforward and correct on the real startup path; the remaining blocker is that the current head still does not have a usable Build signal.
Runtime Chain Rechecked
local example startup
-> SeaTunnelEngineLocalExample.main(...)
-> choose default config path when args are empty
-> getTestConfigFile(configurePath)
-> ClassLoader resource lookup
-> build ClientCommandArgs
-> MasterType.LOCAL
-> SeaTunnel.run(...)
Findings
I did not find a new code-side blocker in the current example fix.
Key evidence I rechecked locally:
- On upstream/dev, SeaTunnelEngineLocalExample still defaults to
/examples/stain_trace_fake_sql_union_to_console.confand also auto-sets/examples/stain_trace_seatunnel.yaml. - Those stain-trace example resources are no longer present under
seatunnel-examples/seatunnel-engine-examples/src/main/resources/examples. - The restored default
/examples/fake_to_console.confdoes exist, and that same example path is already the one used by the cluster client example.
Issue 1: the current head still does not have a usable Build signal
- Location: GitHub Build check
80982848465 - Why this is a blocker:
the current top-level check isACTION_REQUIREDwithWorkflow run detection failed, so the PR still does not have a real build/test signal attached to the latest head. - Better fix:
follow the check-run guidance to get a real Build run attached to this head, for example by enabling Actions in the fork, pushing a no-op trigger commit, or rebasing onto the latest dev if needed. - Severity: High
- Already raised by others: No.
Test Coverage / Stability
- This PR does not add tests.
- For the current scope, the main verification is the actual example-resource lookup path, and the restored default points to an existing resource.
Merge Conclusion
Conclusion: can merge after fixes
- Blocking items
- Issue 1: get the Build workflow to run normally on this head.
- Suggested follow-up
- If the project still wants a stain-trace-specific example later, it would be better to add it back as a separate explicit example instead of overloading the default local example entrypoint.
Overall, the example fix itself looks correct. The only thing still preventing merge from my side is the missing Build signal on the current head.
Contributor
|
Thank you very much for correcting my mistakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running SeaTunnelEngineLocalExample locally failed, but restoring the code and running it successfully
error:

Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.