fix(python/sedonadb): skip RS_ReprojectMatch null-raster test without rasterio - #1096
Merged
paleolimbot merged 1 commit intoJul 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_reproject_match_null_raster_is_nullcallswrite_grid_geotiff, which importsrasterio, but is missing thepytest.importorskip("rasterio")guard that the other rasterio-dependent tests in the same file already have (seetest_reproject_match_int64_uint64_rejectedandtest_reproject_match_sql_smoke). It therefore fails withModuleNotFoundErrorin any environment without rasterio, rather than skipping like its neighbours.This is currently breaking the wheel builds.
CIBW_TEST_REQUIRESinstallspytest adbc_driver_manager geoarrow-pyarrow geopandas duckdb— no rasterio — sopython-wheelsruns fail on this one test:Every
python-wheelsrun onmainhas failed this way for several days, acrosslinux-arm64,linux-x86_64,macOS-arm64,macOS-amd64, andwindows-x86_64, which also skips theexpr,zarr, and nightly-upload jobs.Change
One line, matching the convention used elsewhere in this file and in the other
test_rs_*.pymodules:Verification
Reproduced locally in an environment without rasterio: the test failed before the change, and afterwards the module reports
13 skipped, 0 failed.ruff formatandruff checkare clean.Note
The alternative would be adding
rasteriotoCIBW_TEST_REQUIRESso these tests actually run during wheel builds. Worth considering separately: 12 of the 13 tests in this module already skip in that environment, so raster coverage there is currently minimal. That is a coverage decision rather than a fix for the broken build, so this PR only restores the skip behaviour the module already intends.