Skip to content

fix(ci): unbreak wheel tests and stop linux silently passing them - #1177

Merged
james-willis merged 1 commit into
mainfrom
jw/fix-wheel-test-gate
Aug 19, 2026
Merged

fix(ci): unbreak wheel tests and stop linux silently passing them#1177
james-willis merged 1 commit into
mainfrom
jw/fix-wheel-test-gate

Conversation

@james-willis

Copy link
Copy Markdown
Contributor

Wheel tests have been failing on main since #1167: test_sjoin.py reaches the .geo accessor, which imports sedonadb_expr — not in CIBW_TEST_REQUIRES. Switched to the funcs accessor so the test keeps covering the #1167 regression without the extra dependency.

Linux was failing the same test but reporting success: cibuildwheel copies the project into the container, so the .test_failed marker written to {project} was discarded and the gate saw nothing. Bind-mounts the workspace so the marker lands on the host, alongside the existing vcpkg cache mount.

@james-willis
james-willis marked this pull request as ready for review August 18, 2026 22:40
@james-willis
james-willis requested a review from jiayuasu August 18, 2026 22:40
@james-willis
james-willis merged commit d498441 into main Aug 19, 2026
22 checks passed
@james-willis
james-willis deleted the jw/fix-wheel-test-gate branch August 19, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants