[CI] Clean up pre-commit config and Makefile - #2991
Merged
Merged
Conversation
Added `prek install` to the Makefile target `install` commands to install the hooks in the repo root. This ensures that `prek` will always run on `git commit`. Catching more issues locally before pushing up to GitHub exactly how git hooks are designed to work Also updated the default node language version and the additional dependency prettier https://nodejs.org/en/download https://www.npmjs.com/package/prettier The pre-commit config changes also included removing some unneeded comments, using easy to read multiline regexs and some minor cleanups in spacing/lines
jiayuasu
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
prek installto the Makefile targetinstallcommands to install the hooks in the repo root.This ensures that
prekwill always run ongit commit.Catching more issues locally before pushing up to GitHub exactly how git hooks are designed to work
Also updated the default node language version and the additional dependency prettier
https://nodejs.org/en/download
https://www.npmjs.com/package/prettier
The pre-commit config changes also included removing some unneeded comments, using easy to read multiline regexs and some minor cleanups in spacing/lines
Did you read the Contributor Guide?
Is this PR related to a ticket?
[CI] my subjectWhat changes were proposed in this PR?
As described
How was this patch tested?
Did this PR include necessary documentation updates?