Skip to content

[CI] Clean up pre-commit config and Makefile - #2991

Merged
jiayuasu merged 1 commit into
apache:masterfrom
jbampton:cleanup-pre-commit-makefile
May 23, 2026
Merged

[CI] Clean up pre-commit config and Makefile#2991
jiayuasu merged 1 commit into
apache:masterfrom
jbampton:cleanup-pre-commit-makefile

Conversation

@jbampton

Copy link
Copy Markdown
Member

Added prek install to the Makefile target install commands to install the hooks in the repo root.

This ensures that prek will always run on git commit.

Catching more issues locally before pushing up to GitHub exactly how git hooks are designed to work

Also updated the default node language version and the additional dependency prettier

https://nodejs.org/en/download

https://www.npmjs.com/package/prettier

The pre-commit config changes also included removing some unneeded comments, using easy to read multiline regexs and some minor cleanups in spacing/lines

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • No:
    • this is a CI update. The PR name follows the format [CI] my subject

What changes were proposed in this PR?

As described

How was this patch tested?

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

Added `prek install` to the Makefile target `install` commands to install the hooks in the repo root.

This ensures that `prek` will always run on `git commit`.

Catching more issues locally before pushing up to GitHub exactly how git hooks are designed to work

Also updated the default node language version and the additional dependency prettier

https://nodejs.org/en/download

https://www.npmjs.com/package/prettier

The pre-commit config changes also included removing some unneeded comments, using easy to read multiline regexs and some minor cleanups in spacing/lines
@jbampton jbampton added the pre-commit Pull requests that update pre_commit code label May 23, 2026
@jbampton jbampton added this to the sedona-1.9.1 milestone May 23, 2026
@jbampton
jbampton marked this pull request as ready for review May 23, 2026 04:00
@jbampton
jbampton requested a review from jiayuasu as a code owner May 23, 2026 04:00
@jiayuasu
jiayuasu merged commit c762dd5 into apache:master May 23, 2026
11 checks passed
@jbampton
jbampton deleted the cleanup-pre-commit-makefile branch May 27, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-commit Pull requests that update pre_commit code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants