[GH-3058] Add GeographyTypeSerializer to SedonaFlink - #3059
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds initial Flink runtime support for Sedona’s Geography type by introducing a dedicated Flink TypeSerializer<Geography> and accompanying unit tests, mirroring the existing geometry serializer approach in the Flink module.
Changes:
- Added
GeographyTypeSerializerthat serializesGeographyvalues as a null-safe, length-prefixed byte payload usingGeographyWKBSerializer. - Added a
TypeSerializerSnapshotimplementation for Flink state/schema compatibility. - Added
GeographyTypeSerializerTestcovering point/polygon round-trips, null handling, andcopy()behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flink/src/main/java/org/apache/sedona/flink/GeographyTypeSerializer.java | Introduces a Flink TypeSerializer + snapshot for Sedona Geography, using WKB-based encoding with a length prefix and null sentinel. |
| flink/src/test/java/org/apache/sedona/flink/GeographyTypeSerializerTest.java | Adds unit tests validating serialization/deserialization round-trips and copy() behavior for Geography. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes SedonaFlink: add GeographyTypeSerializer for the Geography type #3058.What changes were proposed in this PR?
This is the first step toward Geography type support in SedonaFlink (#3054).
It adds
GeographyTypeSerializer, a FlinkTypeSerializer<Geography>that letsGeographyvalues flow through the Flink Table/DataStream type system, mirroring the existingGeometryTypeSerializer:org.apache.sedona.common.S2Geography.GeographyWKBSerializer(the same serializer the SparkGeographyUDTuses), so geography bytes are interchangeable across engines.copy(Geography)is implemented via a serialize/deserialize round-trip, sinceGeographyexposes nocopy()/clone().TypeSerializerSnapshotis provided for state schema compatibility, mirroringGeometrySerializerSnapshot.No user-facing functions are registered yet — the
ST_Geog*constructors andCatalogregistration follow in a subsequent PR.How was this patch tested?
Added
GeographyTypeSerializerTest, which round-trips geographies through the FlinkDataOutputView/DataInputViewAPI:copy()for a value and for null.mvn -pl flink test -Dtest=GeographyTypeSerializerTest→ 4 tests pass.Did this PR include necessary documentation updates?