[GH-3103] Bump proj4sedona to 0.1.1 and re-enable RS_CRS round-trip tests - #3106
Merged
Merged
Conversation
…trip tests proj4sedona 0.1.1 fixes the CRS-serialization interop issues that made RS_CRS PROJ-string export non-idempotent for several projected CRSs: WKT1 now emits TOWGS84 in human units, WKT/GeoTools method names are normalized to PROJ short codes on export, canonical PROJ codes are registry-owned, and Polar Stereographic variant selection is consistent across formats. Re-enable the 5 CrsRoundTripComplianceTest cases that were @ignore'd against apache#3103: - Albers Equal Area (EPSG:5070) - Oblique Stereographic (EPSG:28992) - Transverse Mercator / OSGB (EPSG:27700) - Albers Equal Area Australian (EPSG:3577) - Lambert Conformal Conic 2SP / Vicgrid (EPSG:3111) Closes apache#3103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes RS_CRS PROJ-string export is not idempotent for some CRSs (raster CRS-bridge path divergence) #3103What changes were proposed in this PR?
Bumps the
proj4sedonadependency 0.1.0 → 0.1.1 and re-enables the 5CrsRoundTripComplianceTestcases that were@Ignore'd against #3103.proj4sedona 0.1.1 fixes the CRS-serialization interop issues that made
RS_CRSPROJ-string export non-idempotent for several projected CRSs:TOWGS84in human units (arc-seconds / ppm)Polar_Stereographic→stere)Re-enabled cases:
EPSG:5070(Albers),EPSG:28992(Oblique Stereographic),EPSG:27700(OSGB TM),EPSG:3577(Australian Albers),EPSG:3111(Vicgrid LCC 2SP). Transforms were never affected — this was export idempotency only.How was this patch tested?
Built the
commonmodule and the Spark CRS path against proj4sedona 0.1.1:commonfull suite: 1145 tests, 0 failures / 0 errors / 0 skipped — includingCrsRoundTripComplianceTest(81, all cases active, 0 skipped)CRSTransformProj4Test(SparkST_Transform→ proj4sedona): 36, 0 failuresCRSTransformationTest(Spark core CRS): 1, 0 failuresDid this PR include necessary documentation updates?