[CI] Commit website branch changes as the GitHub Actions bot - #3127
Merged
Conversation
The docs workflow configured git with a placeholder identity (test@abc.com). GitHub attributes commits to accounts by email, and that address is owned by an unrelated GitHub user, so the website-branch commits created by the noindex step were attributed to a stranger's account. The pre-existing global config lines also carried a stray "=", which git parsed as the value; mike deploy commits were therefore authored as "= <=>" and attributed to no account at all. Use the GitHub Actions bot identity (github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>) in both places and fix the git config syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[CI] my subjectWhat changes were proposed in this PR?
Commits pushed to the
websitebranch by the docs workflow are attributed to the wrong identities:GitHub Action <test@abc.com>. GitHub resolves commit authorship by email, andtest@abc.comis owned by an unrelated GitHub user, so those commits show up on GitHub as authored by a stranger's account.=(git config --global user.name = "GitHub Action"), which git parses as the value. The effective identity is literally= <=>, which is why everymikedeploy commit on thewebsitebranch is authored as=and attributed to no account.This PR sets the standard GitHub Actions bot identity in both places and fixes the config syntax:
That identity maps to the official Actions bot account and cannot be claimed by any user. The two existing misattributed commits on
websiteare left in history; all future workflow commits will carry the bot identity.How was this patch tested?
actionlint,yamllint, andprettierpass on the workflow file (pre-commit).Did this PR include necessary documentation updates?