[GH-3137] Bump jt-jiffle from 1.1.24 to 1.1.31 - #3138
Merged
Conversation
Brings the per-pixel loop iteration guard (a runaway loop in an RS_MapAlgebra script now fails fast instead of hanging the executor), the atan2 function, and aligns janino with 3.1.12. Adds an atan2 map algebra test and documents the maxIterations system property.
jiayuasu
reviewed
Jul 21, 2026
jiayuasu
reviewed
Jul 21, 2026
…I descriptor Two relocation defects surfaced only on the shaded common artifact: - The maxIterations JVM system-property key string literal in AbstractJiffleRuntime was rewritten by shade to the shaded prefix, so the documented key it.geosolutions.jaiext.jiffle.maxIterations was inert on the shipped jar. Exclude the key string from relocation so the shaded constant keeps its upstream name and matches the docs. - The Janino META-INF/services/org.codehaus.commons.compiler.ICompilerFactory descriptor was copied unchanged while the implementation was relocated, so CompilerFactoryFactory.getDefaultCompilerFactory() failed via SPI on the shaded jar. Add ServicesResourceTransformer to rewrite the descriptor to the relocated class names.
jiayuasu
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
What changes were proposed in this PR?
Bump
jt-jiffle.version1.1.24 → 1.1.31 andjanino-version3.1.9 → 3.1.12 (the version jt-jiffle 1.1.31 is built against; janino is already shaded so Spark is unaffected). Add aMapAlgebraTestcase foratan2(added to Jiffle in 1.1.28 — the test guards against regressing below that) and document the new loop-iteration cap in the map algebra docs.How was this patch tested?
mvn -pl common test -Dtest=MapAlgebraTest— 27/27 pass (JDK 17), including the newatan2test which fails on 1.1.24.mvn -pl common package— verified the shaded jar still relocates antlr/janino/jiffle correctly, withit.geosolutions.jaiext.jiffle.runtime.*left unshaded per the existing shade rules (antlr stays 4.7.1 upstream, so relocations are unchanged).Why bump?
it.geosolutions.jaiext.jiffle.maxIterations(negative disables); now documented in Raster-map-algebra.md.atan2and other math functions added in 1.1.28.Compatibility note
User scripts with legitimately heavy per-pixel loops (>200 iterations) will now fail with a clear error unless the system property is raised — suggest a release-note entry.