[GH-3218] Support integer values in Moran's I - #3220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DOUBLEbefore computing the mean and centered-value statistics.IllegalArgumentExceptionmessages.BIGINTvalues, dotted column names, all-null values, andNaNmeans.Why
Moran's I returns its intermediate aggregates through a typed tuple of
Doublevalues. With an integral input column, Spark inferredz * zand its sum as decimal values, then rejected the attempted upcast fromDECIMAL(38, scale)toDOUBLE.Normalizing the value column at the calculation boundary keeps the intermediate expressions consistent with the existing double-based result contract. Callers can now pass integer counts without adding their own cast.
The same calculation interpolated the mean and configured column names into SQL expressions. That made null or non-finite means fragile and caused dots in literal column names to be parsed as nested paths. Column expressions preserve the intended types and field names throughout the calculation.
Validation
MoranTeston Spark 3.4 / Scala 2.12: 8 tests passed.MoranTeston Spark 3.5.8 / Scala 2.12: 8 tests passed.MoranTeston Spark 4.1.1 / Scala 2.13: 8 tests passed.Fixes #3218.