[GH-2392] Test single-member GeometryCollection - #3326
Merged
Conversation
ryux1
force-pushed
the
ryux1/test-empty-geometries
branch
from
September 6, 2026 02:18
ea922dc to
daeb0a5
Compare
ryux1
force-pushed
the
ryux1/test-empty-geometries
branch
from
September 6, 2026 04:04
6eaccfb to
2bba3dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
The contributor rules and Python development/test instructions were reviewed while preparing this patch.
Is this PR related to a ticket?
Yes. Partially addresses #2392.
What changes were proposed in this PR?
Extend the shared GeoSeries parity fixtures with a missing single-member GeometryCollection containing a closed LineString. Because
self.geomcollectionis part ofself.geoms, the case flows through the existing Sedona-versus-GeoPandas checks, including construction, serialization, predicates, measurements, transformations, andis_closed.The initial revision also included a collection whose members were all typed empty geometries. The full matrix demonstrated a distinct
to_arrowWKB dimensionality mismatch for that shape, now tracked separately in #3329; it was removed here rather than masking a real defect with an expected failure.How was this patch tested?
git diff --checkis_empty,is_valid,is_closed,has_z,geom_type,length,area, andcount_geometriesexplodevariants passed (5 tests)test_coverage_validationreached an internal JVM function absent from the released Sedona 1.9.0 shaded JAR used locallyDid this PR include necessary documentation updates?
No. This only expands test coverage and does not change a public API.