[SCB-1304]FallbackPolicy#getFallbackResponse add Throwable#1231
Merged
liubao68 merged 1 commit intoapache:masterfrom Jun 27, 2019
Merged
[SCB-1304]FallbackPolicy#getFallbackResponse add Throwable#1231liubao68 merged 1 commit intoapache:masterfrom
liubao68 merged 1 commit intoapache:masterfrom
Conversation
pengliang56
force-pushed
the
addFallbackException
branch
from
bef31f8 to
5eefcff
Compare
pengliang56
changed the title
wujimin
reviewed
Jun 4, 2019
|
|
||
| @Override | ||
| public Response getFallbackResponse(Invocation invocation) { | ||
| public Response getFallbackResponse(Invocation invocation, Throwable error) { |
Contributor
There was a problem hiding this comment.
need change second parameter from null to error of createBizkeeperException, or not?
if need, then need add UT and IT for this.
Contributor
There was a problem hiding this comment.
It's better to use error as the parameter, I think
wujimin
reviewed
Jun 4, 2019
| String name(); | ||
|
|
||
| Response getFallbackResponse(Invocation invocation); | ||
| Response getFallbackResponse(Invocation invocation, Throwable error); |
Contributor
There was a problem hiding this comment.
I think the change is fine. Users can change their implementations easily.
liubao68
reviewed
Jun 20, 2019
|
|
||
| @Override | ||
| public Response getFallbackResponse(Invocation invocation, Throwable error) { | ||
| return Response.succResp("test"); |
Contributor
There was a problem hiding this comment.
This test case is better to include some message from error and check it.
pengliang56
force-pushed
the
addFallbackException
branch
from
5eefcff to
4d0309d
Compare
liubao68
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.