-
Notifications
You must be signed in to change notification settings - Fork 822
[SCB-1304]FallbackPolicy#getFallbackResponse add Throwable #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,11 +30,11 @@ public String name() { | |
| } | ||
|
|
||
| @Override | ||
| public Response getFallbackResponse(Invocation invocation) { | ||
| public Response getFallbackResponse(Invocation invocation, Throwable error) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. need change second parameter from null to error of createBizkeeperException, or not? if need, then need add UT and IT for this.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's better to use error as the parameter, I think |
||
| return Response.failResp(invocation.getInvocationType(), | ||
| BizkeeperExceptionUtils | ||
| .createBizkeeperException(BizkeeperExceptionUtils.SERVICECOMB_BIZKEEPER_FALLBACK, | ||
| null, | ||
| error, | ||
| invocation.getOperationMeta().getMicroserviceQualifiedName())); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems not compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is fine. Users can change their implementations easily.