Skip to content

[SCB-1997] Small improvement when Muticastscoket receive data #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liubao68 merged 1 commit into from
Jun 13, 2020
Merged

[SCB-1997] Small improvement when Muticastscoket receive data #1827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 50 additions & 42 deletions ...gistry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/server/ServerUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,57 +172,36 @@ private static Map<String, String> getMapFromString(String inputStr) {
return map;
}

private static void initMulticastSocket() throws IOException {
multicastSocket = new MulticastSocket(PORT);
group = InetAddress.getByName(GROUP);
multicastSocket.joinGroup(group); // need to join the group to be able to receive the data
}

private static void startListenerForRegisterUnregisterEvent() {
try {
byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE];
Comment on lines 181 to 183

@liubao68 liubao68 Jun 12, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cyclomatic complexity of startListenerForRegisterUnregisterEvent is a bit too high, can be refactored.

multicastSocket = new MulticastSocket(PORT);
group = InetAddress.getByName(GROUP);
multicastSocket.joinGroup(group); // need to join the group to be able to receive the data

initMulticastSocket();
while (true) {
DatagramPacket receivePacketBuffer = new DatagramPacket(buffer, buffer.length);
multicastSocket.receive(receivePacketBuffer);
int receivePacketBufferLength = receivePacketBuffer.getLength();
if (receivePacketBufferLength > 0) {
String receivedPacketString = new String(receivePacketBuffer.getData(), 0,
receivePacketBufferLength, ENCODE).trim();

if (receivedPacketString.length() < 2
|| !receivedPacketString.startsWith(MAP_STRING_LEFT) || !receivedPacketString
.endsWith(MAP_STRING_RIGHT)) {
LOGGER.error("Wrong format of the input received string: {}", receivedPacketString);
continue;
}

Map<String, String> receivedStringMap = getMapFromString(receivedPacketString);
String event = receivedStringMap.get(EVENT);
if (StringUtils.isEmpty(event)) {
LOGGER.warn("Received event is null or doesn't have event type. {}", receivedStringMap);
continue;
}

if (event.equals(REGISTER_EVENT)) {
LOGGER.info("Received REGISTER event{}", receivedStringMap);
zeroConfigRegistryService.registerMicroserviceInstance(receivedStringMap);
} else if (event.equals(UNREGISTER_EVENT)) {
LOGGER.info("Received UNREGISTER event{}", receivedStringMap);
zeroConfigRegistryService.unregisterMicroserviceInstance(receivedStringMap);
} else if (event.equals(HEARTBEAT_EVENT)) {
// check if received event is for service instance itself
if (isSelfServiceInstance(receivedStringMap)) {
continue;
}
zeroConfigRegistryService.heartbeat(receivedStringMap);
} else {
LOGGER.error("Unrecognized event type. event: {}", event);
try {
multicastSocket.receive(receivePacketBuffer);
} catch (Throwable t) {
LOGGER.error("Caught error when receiving the data packet", t.getMessage());
if (multicastSocket.isClosed()) {
LOGGER.info("MulticastSocket is closed. Going to restart it.");
initMulticastSocket();
}
continue;
}
}

String receivedEventString = new String(receivePacketBuffer.getData(), 0,
receivePacketBuffer.getLength(), ENCODE).trim();
handleReceivedEvent(receivedEventString);
}
} catch (IOException e) {
//failed to create MulticastSocket, the PORT might have been occupied
LOGGER.error(
"Failed to create MulticastSocket object for receiving register/unregister event" + e);
throw new IllegalStateException(
"Failed to create MulticastSocket object. Zero-Config init failed! ", e);
} finally {
if (multicastSocket != null) {
try {
Expand All @@ -236,6 +215,35 @@ private static void startListenerForRegisterUnregisterEvent() {
}
}

private static void handleReceivedEvent(String receivedString) {
if (receivedString.length() < 2
|| !receivedString.startsWith(MAP_STRING_LEFT) || !receivedString
.endsWith(MAP_STRING_RIGHT)) {
LOGGER.warn("Wrong format of the received Event string. {}", receivedString);
return;
}

Map<String, String> receivedStringMap = getMapFromString(receivedString);
String event = receivedStringMap.get(EVENT);
if (StringUtils.isEmpty(event)) {
LOGGER.warn("There is no Event property defined. {}", receivedStringMap);
return;
}

if (event.equals(REGISTER_EVENT)) {
LOGGER.info("Received REGISTER event{}", receivedStringMap);
zeroConfigRegistryService.registerMicroserviceInstance(receivedStringMap);
} else if (event.equals(UNREGISTER_EVENT)) {
LOGGER.info("Received UNREGISTER event{}", receivedStringMap);
zeroConfigRegistryService.unregisterMicroserviceInstance(receivedStringMap);
} else if (event.equals(HEARTBEAT_EVENT) && !isSelfServiceInstance(receivedStringMap)) {
zeroConfigRegistryService.heartbeat(receivedStringMap);
} else {
LOGGER.error("Unrecognized event type. event: {}", event);
}

}

private static boolean isSelfServiceInstance(Map<String, String> receivedStringMap) {
Map<String, String> serviceInstanceMapForHeartbeat = ClientUtil
.getServiceInstanceMapForHeartbeat();
Expand Down