Skip to content

[SCB-2381] support upload to default directory - #2709

Merged
liubao68 merged 4 commits into
apache:masterfrom
david6969xin:branch_master_2381
Feb 8, 2022
Merged

[SCB-2381] support upload to default directory#2709
liubao68 merged 4 commits into
apache:masterfrom
david6969xin:branch_master_2381

Conversation

@david6969xin

Copy link
Copy Markdown
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter

codecov-commenter commented Jan 26, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.23%. Comparing base (79db194) to head (0bb140a).
⚠️ Report is 1591 commits behind head on master.

Files with missing lines Patch % Lines
...rvicecomb/transport/rest/servlet/ServletUtils.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2709   +/-   ##
=========================================
  Coverage     77.22%   77.23%           
- Complexity     1412     1413    +1     
=========================================
  Files          1608     1608           
  Lines         42976    42974    -2     
  Branches       3643     3641    -2     
=========================================
  Hits          33190    33190           
+ Misses         8263     8259    -4     
- Partials       1523     1525    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +91 to +92
String location = DynamicPropertyFactory.getInstance()
.getStringProperty(RestConst.UPLOAD_DIR, RestConst.UPLOAD_DEFAULT_DIR).get();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@david6969xin

Copy link
Copy Markdown
Contributor Author

retrigger cl

@david6969xin david6969xin reopened this Feb 8, 2022
@liubao68 liubao68 closed this Feb 8, 2022
@liubao68

liubao68 commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

retrigger ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants