[SCB-2739] fix flaky tests in clients - #3497
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3497 +/- ##
============================================
- Coverage 74.38% 74.38% -0.01%
Complexity 670 670
============================================
Files 1589 1589
Lines 39830 39830
Branches 3633 3633
============================================
- Hits 29628 29626 -2
- Misses 8721 8722 +1
- Partials 1481 1482 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liubao68
approved these changes
Nov 24, 2022
lbc97
pushed a commit
to lbc97/servicecomb-java-chassis
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The function


writeValueAsStringreturns the order of elements in no fix order and can hamper the functionality ofmockfunction.For the test
#TestSendHeartBeats, these are 2 values I received from the functionwriteValueAsStringWe are only changing the code to take any string value for the 3rd parameter and the first 2 parameter will be checked.
Similar code is present in other test functions -
TestGetServiceInstanceMessage,TestDeleteServiceInstance, where all the parameters are mocked for any value.Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.