[#3850] Fix the problem when setting content-type by ResponseEntity.header() does not take effect#3852
Conversation
Sayaka617
changed the title
| if (responseEx.getContentType() != null) { | ||
| responseEx.setHeader(HttpHeaders.CONTENT_TYPE.toString(), responseEx.getContentType()); | ||
| } else { | ||
| responseEx.setHeader(HttpHeaders.CONTENT_TYPE.toString(), part.getContentType()); | ||
| } |
There was a problem hiding this comment.
Do you find this problem in spring boot embedded tomcat or standalone tomcat? And would you mind to add a test case in demo folders (there are many test cases and you can run each demo from your IDE).
There was a problem hiding this comment.
it's in spring boot embedded tomcat .
Of course , I'll add some test cases .
|
@Sayaka617 Do not use force-push if possible, so that we can see what's changed after last review. Do don't worry about the commits, we can use squash merge when merge the PR. |
Codecov Report
@@ Coverage Diff @@
## master #3852 +/- ##
=========================================
Coverage 43.97% 43.97%
+ Complexity 6087 6085 -2
=========================================
Files 1557 1557
Lines 38278 38288 +10
Branches 3512 3513 +1
=========================================
+ Hits 16833 16839 +6
- Misses 20134 20139 +5
+ Partials 1311 1310 -1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
okay，i got it . I'll avoid this next time . thank you |
|
@Sayaka617 This PR is OK now. Do you mind to cherry-pick this PR to 2.8.x branch? |
Of course, I've just create a backport pr to 2.8.x. |
3 participants
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.