Search before asking
Apache ShenYu Component
shenyu-plugin
What happened
AiTokenLimiterPlugin builds the Redis counter key only from a fixed prefix and the configured resolver value:
private static final String REDIS_KEY_PREFIX = "SHENYU:AI:TOKENLIMIT:";
...
String cacheKey = REDIS_KEY_PREFIX + getCacheKey(exchange, tokenLimitType, keyName);
getCacheKey(...) returns only request-derived data such as IP, URI, header, parameter, cookie, or context path:
case IP -> Objects.requireNonNull(request.getRemoteAddress()).getHostString();
case URI -> request.getURI().getPath();
case HEADER -> request.getHeaders().getFirst(keyName);
case PARAMETER -> request.getQueryParams().getFirst(keyName);
case COOKIE -> { ... }
default -> exchange.getAttribute(Constants.CONTEXT_PATH);The rule id, selector id, plugin id, and namespace are not included. Therefore two different AI token limiter rules can share the same Redis counter whenever their resolver value is the same.
For example, two separate rules using aiTokenLimitType=uri for /v1/chat/completions but with different tokenLimit values will both read and increment:
SHENYU:AI:TOKENLIMIT:/v1/chat/completions
Usage from one rule can exhaust the other rule's quota, even if they belong to different selectors/routes.
For comparison, the regular RateLimiterPlugin scopes Redis keys with rule.getId() + resolverKey before passing them to the rate limiter.
Expected behavior
AI token limiter counters should be scoped at least by rule id, and likely also by namespace/selector as needed, before appending the request-derived resolver value. Independent limiter rules should not share Redis counters unless explicitly configured to do so.
How to reproduce
- Enable
ai-token-limiter.
- Configure two different rules for different selectors/routes that both resolve to the same key value, for example
aiTokenLimitType=uri and request path /v1/chat/completions.
- Set different
tokenLimit values for the two rules.
- Send requests through the first rule until it records token usage.
- Send a request through the second rule.
- The second rule reads the same Redis key and is affected by the first rule's token usage.
Debug logs
No response
Environment
Current master branch.
Are you willing to submit a PR?
Search before asking
Apache ShenYu Component
shenyu-plugin
What happened
AiTokenLimiterPluginbuilds the Redis counter key only from a fixed prefix and the configured resolver value:getCacheKey(...)returns only request-derived data such as IP, URI, header, parameter, cookie, or context path:The rule id, selector id, plugin id, and namespace are not included. Therefore two different AI token limiter rules can share the same Redis counter whenever their resolver value is the same.
For example, two separate rules using
aiTokenLimitType=urifor/v1/chat/completionsbut with differenttokenLimitvalues will both read and increment:Usage from one rule can exhaust the other rule's quota, even if they belong to different selectors/routes.
For comparison, the regular
RateLimiterPluginscopes Redis keys withrule.getId() + resolverKeybefore passing them to the rate limiter.Expected behavior
AI token limiter counters should be scoped at least by rule id, and likely also by namespace/selector as needed, before appending the request-derived resolver value. Independent limiter rules should not share Redis counters unless explicitly configured to do so.
How to reproduce
ai-token-limiter.aiTokenLimitType=uriand request path/v1/chat/completions.tokenLimitvalues for the two rules.Debug logs
No response
Environment
Current
masterbranch.Are you willing to submit a PR?