Skip to content

feat(dubbo): support dubbo3 tri protocol#4286

Merged
JooKS-me merged 6 commits into
apache:masterfrom
fantiq:feat_support_dubbo3_tri_protocol
Dec 26, 2022
Merged

feat(dubbo): support dubbo3 tri protocol#4286
JooKS-me merged 6 commits into
apache:masterfrom
fantiq:feat_support_dubbo3_tri_protocol

Conversation

@fantiq

@fantiq fantiq commented Dec 26, 2022

Copy link
Copy Markdown
Contributor

support dubbo3 tri and dubbo protocol

i add a field on rpcExt, on client write the dubbo protocol in the metadata. on shunyu gateway, create reference by the metadata rpcExt protocol.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@JooKS-me

Copy link
Copy Markdown
Member

A good job.
Pls check the ci, there are some style error.
image

@fantiq

fantiq commented Dec 26, 2022

Copy link
Copy Markdown
Contributor Author

A good job. Pls check the ci, there are some style error. image

fixed

@JooKS-me

Copy link
Copy Markdown
Member

still 2 style error
image

@codecov-commenter

codecov-commenter commented Dec 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4286 (9030915) into master (0eab567) will decrease coverage by 0.00%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##             master    #4286      +/-   ##
============================================
- Coverage     68.98%   68.98%   -0.01%     
- Complexity     7335     7340       +5     
============================================
  Files           994      994              
  Lines         28013    28020       +7     
  Branches       2483     2485       +2     
============================================
+ Hits          19326    19330       +4     
- Misses         7210     7214       +4     
+ Partials       1477     1476       -1     
Impacted Files Coverage Δ
...alibaba/dubbo/AlibabaDubboServiceBeanListener.java 0.00% <0.00%> (ø)
...t/apache/dubbo/ApacheDubboServiceBeanListener.java 0.00% <0.00%> (ø)
...e/shenyu/plugin/dubbo/common/cache/DubboParam.java 89.28% <0.00%> (-10.72%) ⬇️
...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java 77.27% <100.00%> (+0.26%) ⬆️
...gin/apache/dubbo/cache/ApacheDubboConfigCache.java 64.76% <100.00%> (+0.33%) ⬆️
...che/shenyu/sync/data/http/HttpSyncDataService.java 85.71% <0.00%> (-4.09%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 64.00% <0.00%> (+1.33%) ⬆️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 56.38% <0.00%> (+4.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fantiq

fantiq commented Dec 26, 2022

Copy link
Copy Markdown
Contributor Author

still 2 style error image

fixed

@JooKS-me JooKS-me left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<dependency>
<groupId>org.apache.shenyu</groupId>
<artifactId>shenyu-spring-boot-starter-plugin-apache-dubbo</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo</artifactId>
<version>${apache.dubbo.version}</version>
</dependency>
<dependency>
<groupId>org.apache.curator</groupId>
<artifactId>curator-client</artifactId>
<version>${curator.version}</version>
<exclusions>
<exclusion>
<artifactId>log4j</artifactId>
<groupId>log4j</groupId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.apache.curator</groupId>
<artifactId>curator-framework</artifactId>
<version>${curator.version}</version>
</dependency>
<dependency>
<groupId>org.apache.curator</groupId>
<artifactId>curator-recipes</artifactId>
<version>${curator.version}</version>
</dependency>

Please change the dependencies in integrated-test-combination to

<dependency>
            <groupId>org.apache.shenyu</groupId>
            <artifactId>shenyu-spring-boot-starter-plugin-apache-dubbo</artifactId>
            <version>${project.version}</version>
        </dependency>
        <dependency>
            <groupId>org.apache.dubbo</groupId>
            <artifactId>dubbo</artifactId>
            <version>3.1.1</version>
        </dependency>
        <dependency>
            <groupId>org.apache.dubbo</groupId>
            <artifactId>dubbo-dependencies-zookeeper</artifactId>
            <version>3.1.1</version>
            <type>pom</type>
        </dependency>

@JooKS-me JooKS-me left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JooKS-me
JooKS-me merged commit 3aba218 into apache:master Dec 26, 2022
@JooKS-me JooKS-me mentioned this pull request Dec 26, 2022
3 tasks
@JooKS-me JooKS-me added this to the 2.5.1 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants