[ISSUE-6523] Add break after successful long polling to avoid unnecessary retries - #6901
Open
YALI58 wants to merge 1 commit into
Open
[ISSUE-6523] Add break after successful long polling to avoid unnecessary retries#6901YALI58 wants to merge 1 commit into
YALI58 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
HttpLongPollingTask.run()retries failed long-poll requests with afor (time = 1; time <= retryTimes; time++)loop, but it does not leave that retry loop after a successfuldoLongPolling(server)call. A single outer loop can therefore perform 10 successful long-poll requests back-to-back instead of one.Fix
Added
breakafterdoLongPolling(server)succeeds so the retry loop exits on success and only continues on failure.Closes #6523