fix(plugin): add exec_module to execute the module code #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the plugin installation process to support Python 3.12 by replacing the deprecated module loading approach with a method that uses module specs and explicitly executes the module code.
- Replaces importer.find_module().load_module() with importer.find_spec(), module_from_spec(), and spec.loader.exec_module().
- Adjusts the module loading mechanism to align with Python 3.12 changes.
| plugin = importer.find_module(modname).load_module(modname) | ||
| else: | ||
| plugin = importlib.util.module_from_spec(importer.find_spec(modname)) | ||
| spec = importer.find_spec(modname) |
There was a problem hiding this comment.
Consider adding a check to ensure 'spec' is not None before invoking 'spec.loader.exec_module(plugin)' to prevent a potential AttributeError if the module spec is not found.
Suggested change
| spec = importer.find_spec(modname) | |
| spec = importer.find_spec(modname) | |
| if spec is None: | |
| logger.warning("Module spec for plugin %s could not be found, skipping installation.", modname) | |
| continue |
shenxiangzhuang
changed the title
Contributor
Author
|
And, shall we release the |
kezhenxu94
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/skywalking#13310