Skip to content

fix(plugin): add exec_module to execute the module code #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kezhenxu94 merged 1 commit into from
Jun 11, 2025
Merged

fix(plugin): add exec_module to execute the module code #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion skywalking/plugins/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ def install():
if sys.version_info < (3, 12):
plugin = importer.find_module(modname).load_module(modname)
else:
plugin = importlib.util.module_from_spec(importer.find_spec(modname))
spec = importer.find_spec(modname)
Copy link

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check to ensure 'spec' is not None before invoking 'spec.loader.exec_module(plugin)' to prevent a potential AttributeError if the module spec is not found.

Suggested change
spec = importer.find_spec(modname)
spec = importer.find_spec(modname)
if spec is None:
logger.warning("Module spec for plugin %s could not be found, skipping installation.", modname)
continue

Copilot uses AI. Check for mistakes.
plugin = importlib.util.module_from_spec(spec)
spec.loader.exec_module(plugin)

# todo: refactor the version checker, currently it doesn't really work as intended
supported = pkg_version_check(plugin)
Expand Down
Loading