Skip to content

Integrating Apache SkyWalking with source code#411

Merged
wu-sheng merged 27 commits into
apache:masterfrom
BFergerson:master
Apr 14, 2022
Merged

Integrating Apache SkyWalking with source code#411
wu-sheng merged 27 commits into
apache:masterfrom
BFergerson:master

Conversation

@BFergerson

Copy link
Copy Markdown
Member

I used Fiverr to translate the blog post to try to better support Chinese users. I'm not sure how good it is so if you think it's a bad translation I can remove it.

Comment thread content/zh/2022-03-25-integrating-skywalking-with-source-code/index.md Outdated
@Superskyyy

Copy link
Copy Markdown
Member

I will say the translation looks close enough. But I can tell it's translated by someone out of our domain so there are errors and weird phrases.

Let me help you to fix the translation. But we could merge this or the English part first.

@BFergerson

Copy link
Copy Markdown
Member Author

I will say the translation looks close enough. But I can tell it's translated by someone out of our domain so there are errors and weird phrases.

Let me help you to fix the translation. But we could merge this or the English part first.

That would be greatly appreciated. I'm in no rush to post so we can keep this PR open. I'll update the dates before merging if you need more than a day.

@wu-sheng

Copy link
Copy Markdown
Member

@Superskyyy Should I keep this open?

@Superskyyy

Copy link
Copy Markdown
Member

@Superskyyy Should I keep this open?

Yes please keep it open for a day or two, I will do the fixes asap.

@Superskyyy
Superskyyy marked this pull request as draft March 25, 2022 18:53
@Superskyyy

Copy link
Copy Markdown
Member

Hi just an update, I got some other work to finish this week, I will make the fix happen by Friday.

@BFergerson

BFergerson commented Mar 29, 2022

Copy link
Copy Markdown
Member Author

Hi just an update, I got some other work to finish this week, I will make the fix happen by Friday.

Sounds good, thanks for the update.

@wu-sheng

Copy link
Copy Markdown
Member

@Superskyyy Any update?

@BFergerson

Copy link
Copy Markdown
Member Author

@wu-sheng, I'd like to publish just the English version. We can publish the Chinese version if/when that's finished.

@BFergerson
BFergerson marked this pull request as ready for review April 14, 2022 17:55
@Superskyyy

Superskyyy commented Apr 14, 2022

Copy link
Copy Markdown
Member

Oh wait so sorry! actually, I have it ready, can you pick the translated text from here https://github.com/Superskyyy/skywalking-website/blob/translated/test @BFergerson

I just proofread it, sorry I was busy over last week, the translation has been ready for a while.

@BFergerson

Copy link
Copy Markdown
Member Author

@Superskyyy, thanks for the translations!

@wu-sheng, this is ready to go.

@Superskyyy

Superskyyy commented Apr 14, 2022

Copy link
Copy Markdown
Member

Nice, is the preview deployment failure expected?

@wu-sheng

Copy link
Copy Markdown
Member

Preview could fail due to GitHub API limit.

@wu-sheng
wu-sheng merged commit 46e7370 into apache:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants