Add unit tests for alarm-plugin module#2542
Merged
wu-sheng merged 2 commits intoapache:masterfrom Apr 30, 2019
Merged
Conversation
wu-sheng
reviewed
Apr 27, 2019
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
I have a question for one test case.
...in/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/NotifyHandlerTest.java
Outdated
Show resolved
Hide resolved
flycash
force-pushed
the
test-alarm-plugin
branch
2 times, most recently
from
3799696 to
e2e3968
Compare
flycash
force-pushed
the
test-alarm-plugin
branch
from
e2e3968 to
586dad6
Compare
Member
|
6.1 release is on the way, so I will hold this PR for a while. |
wu-sheng
added
backend
Member
|
Ref #2438 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Bug fix
Bug description.
How to fix?
New feature or improvement