Skip to content

Fix wrong example in doc, sync Python E2E version and adjust E2E#8751

Merged
wu-sheng merged 2 commits into
masterfrom
chore/instance-properties
Apr 7, 2022
Merged

Fix wrong example in doc, sync Python E2E version and adjust E2E#8751
wu-sheng merged 2 commits into
masterfrom
chore/instance-properties

Conversation

@kezhenxu94

@kezhenxu94 kezhenxu94 commented Mar 26, 2022

Copy link
Copy Markdown
Member
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@kezhenxu94 kezhenxu94 added documentation Provide documents related issue or pull request only. test Test requirements about performance, feature or before release. labels Mar 26, 2022
@kezhenxu94 kezhenxu94 added this to the 9.0.0 milestone Mar 26, 2022
@Superskyyy

Superskyyy commented Mar 26, 2022

Copy link
Copy Markdown
Member

Umm looks like Python e2e fails mysteriously.
Is it just me or the CI summary in this repo won't open properly?
image

@Superskyyy

Superskyyy commented Mar 26, 2022

Copy link
Copy Markdown
Member

I think I found the problem.

It should be

RUN make setup-test install

in the Dockerfile, requests is no longer a default setup dependency since end of 2020...

@kezhenxu94
kezhenxu94 dismissed a stale review via 0c9a1f6 April 2, 2022 22:41
@kezhenxu94
kezhenxu94 force-pushed the chore/instance-properties branch 2 times, most recently from 0c9a1f6 to 95ae39e Compare April 2, 2022 22:42
@wu-sheng wu-sheng modified the milestones: 9.0.0, 9.1.0 Apr 6, 2022
@kezhenxu94
kezhenxu94 force-pushed the chore/instance-properties branch from 95ae39e to 0afedbf Compare April 7, 2022 00:50
wu-sheng
wu-sheng previously approved these changes Apr 7, 2022
View reviewed changes
@kezhenxu94
kezhenxu94 force-pushed the chore/instance-properties branch from 0afedbf to 755070f Compare April 7, 2022 02:36
@kezhenxu94

kezhenxu94 commented Apr 7, 2022

Copy link
Copy Markdown
Member Author

@wu-sheng should be good to merge now

@wu-sheng
wu-sheng merged commit 118ba3b into master Apr 7, 2022
@kezhenxu94
kezhenxu94 deleted the chore/instance-properties branch April 7, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes
@Superskyyy Superskyyy Awaiting requested review from Superskyyy

Assignees

No one assigned

Labels

documentation Provide documents related issue or pull request only. test Test requirements about performance, feature or before release.

Projects

None yet

Milestone

9.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kezhenxu94 @Superskyyy @wu-sheng