Skip to content

Gradle should fail clearly on too-new JDK#1145

Merged
risdenk merged 1 commit intoapache:mainfrom
risdenk:gradle-java-version
Oct 28, 2022
Merged

Gradle should fail clearly on too-new JDK#1145
risdenk merged 1 commit intoapache:mainfrom
risdenk:gradle-java-version

Conversation

@risdenk
Copy link
Contributor

@risdenk risdenk commented Oct 28, 2022

Gradle will give a very confusing error using the
wrong JDK, let's make it absolutely clear.

Port the following to Solr with minor adjustments (minimum JDK 11)

Co-authored-by: Dawid Weiss dawid.weiss@carrotsearch.com
Co-authored-by: Robert Muir rmuir@apache.org

Gradle will give a very confusing error using the
wrong JDK, let's make it absolutely clear.

Port the following to Solr
* apache/lucene#819
* apache/lucene#11889

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
Co-authored-by: Robert Muir <rmuir@apache.org>
@risdenk
Copy link
Contributor Author

risdenk commented Oct 28, 2022

This should help with things like https://issues.apache.org/jira/browse/SOLR-16431

Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not involved in this code. So change looks fine, but haven't tested on Windows. Could maybe test it tomorrow. If it is same code like in Lucene, just merge it!

@risdenk risdenk merged commit 81f78b7 into apache:main Oct 28, 2022
@risdenk risdenk deleted the gradle-java-version branch October 28, 2022 18:34
risdenk added a commit that referenced this pull request Oct 28, 2022
Gradle will give a very confusing error using the
wrong JDK, let's make it absolutely clear.

Port the following to Solr
* apache/lucene#819
* apache/lucene#11889

Co-authored-by: Robert Muir <rmuir@apache.org>
Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants