Skip to content

SOLR-16152 Print helpful error instead of NPE when using bin/solr package in standalone#1150

Merged
janhoy merged 2 commits into
apache:mainfrom
janhoy:solr16152-package-cli-npe
Nov 10, 2022
Merged

SOLR-16152 Print helpful error instead of NPE when using bin/solr package in standalone#1150
janhoy merged 2 commits into
apache:mainfrom
janhoy:solr16152-package-cli-npe

Conversation

@janhoy
Copy link
Copy Markdown
Contributor

@janhoy janhoy commented Oct 30, 2022 •
edited
Loading

https://issues.apache.org/jira/browse/SOLR-16152

Printout will be

> bin/solr package
org.apache.solr.common.SolrException: Package manager runs only in SolrCloud
	at org.apache.solr.util.PackageTool.runImpl(PackageTool.java:81)
	at org.apache.solr.util.SolrCLI$ToolBase.runTool(SolrCLI.java:170)
	at org.apache.solr.util.SolrCLI.main(SolrCLI.java:308)

ERROR: Package manager runs only in SolrCloud

@janhoy janhoy requested review from anshumg and epugh October 31, 2022 21:30
@janhoy
Copy link
Copy Markdown
Contributor Author

janhoy commented Nov 6, 2022

Any final comments before I merge this?

@janhoy janhoy merged commit 7683228 into apache:main Nov 10, 2022
@janhoy janhoy deleted the solr16152-package-cli-npe branch November 10, 2022 18:24
janhoy added a commit that referenced this pull request Nov 10, 2022
@janhoy
SOLR-16152 Print helpful error instead of NPE when using bin/solr pac…
a341aa0 
…kage in standalone (#1150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risdenk risdenk risdenk approved these changes

@noblepaul noblepaul Awaiting requested review from noblepaul

@gerlowskija gerlowskija Awaiting requested review from gerlowskija

@anshumg anshumg Awaiting requested review from anshumg

@epugh epugh Awaiting requested review from epugh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janhoy @risdenk