Skip to content

Modifying github actions to run on all branches including ones with slashes#1157

Merged
risdenk merged 1 commit intoapache:mainfrom
cowpaths:SOLR-16516-github-actions-pattern
Nov 28, 2022
Merged

Modifying github actions to run on all branches including ones with slashes#1157
risdenk merged 1 commit intoapache:mainfrom
cowpaths:SOLR-16516-github-actions-pattern

Conversation

@justinrsweeney
Copy link
Contributor

@justinrsweeney justinrsweeney commented Nov 1, 2022

https://issues.apache.org/jira/browse/SOLR-16516

Description

This change modifies the Github Actions to execute on any PR opened against any branch, including branches with a / in the branch name. This can be useful for organizations that have forked the Solr repo and want to run checks against additional branches.

Solution

This is a simple change to the pattern used to be ** instead of * to include branches with slashes. More info here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet.

Tests

N/A

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@magibney
Copy link
Contributor

magibney commented Nov 3, 2022

This makes sense to me; seems like maybe just an oversight rather than an intentional decision. @anshumg could you take a quick look and confirm/contradict?

@justinrsweeney
Copy link
Contributor Author

@risdenk Thanks for approving, is this something we could merge into main and also backport to branch_9x?

@risdenk risdenk merged commit e19be90 into apache:main Nov 28, 2022
@risdenk
Copy link
Contributor

risdenk commented Nov 28, 2022

@justinrsweeney yup merged to main and will backport to branch_9x shortly.

@risdenk
Copy link
Contributor

risdenk commented Nov 28, 2022

backported to branch_9x as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants