Modifying github actions to run on all branches including ones with slashes#1157
Merged
risdenk merged 1 commit intoapache:mainfrom Nov 28, 2022
Merged
Conversation
Contributor
|
This makes sense to me; seems like maybe just an oversight rather than an intentional decision. @anshumg could you take a quick look and confirm/contradict? |
risdenk
approved these changes
Nov 10, 2022
Contributor
Author
|
@risdenk Thanks for approving, is this something we could merge into main and also backport to branch_9x? |
Contributor
|
@justinrsweeney yup merged to main and will backport to branch_9x shortly. |
risdenk
pushed a commit
that referenced
this pull request
Nov 28, 2022
Contributor
|
backported to branch_9x as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16516
Description
This change modifies the Github Actions to execute on any PR opened against any branch, including branches with a
/in the branch name. This can be useful for organizations that have forked the Solr repo and want to run checks against additional branches.Solution
This is a simple change to the pattern used to be
**instead of*to include branches with slashes. More info here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet.Tests
N/A
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.