Skip to content

Update search-process.png#1180

Merged
epugh merged 2 commits intoapache:mainfrom
AkashTpg:main
Nov 24, 2022
Merged

Update search-process.png#1180
epugh merged 2 commits intoapache:mainfrom
AkashTpg:main

Conversation

@AkashTpg
Copy link
Contributor

@AkashTpg AkashTpg commented Nov 15, 2022

(search-process diagram improvement)
changes made to following:-
qt :
previous text : selects a RequestHandler for a query using /select (by default, the DisMax RequestHandler is used)
changed to : selects a RequestHandler for a query using /select

defType :
previous text : selects a query parser for the query (by default, uses whatever has been configured for the RequestHandler )
changed to : selects a query parser for the query if configured for RequestHandler, otherwise by default "Lucene" query parser is used

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

changes made to following:-
qt :
previous text :  selects a RequestHandler for a query using /select (by default, the DisMax RequestHandler is used)
changed to : selects a RequestHandler for a query using /select

defType :
previous text :
changed to : selects a query parser for the query if configured for RequestHandler, otherwise by default "Lucene" query parser is used
@epugh
Copy link
Contributor

epugh commented Nov 15, 2022

This makes sense to me, however would love someone else to eyeball it to... @risdenk ?

@epugh
Copy link
Contributor

epugh commented Nov 15, 2022

Thanks @risdenk for eyeballs, and @AkashTpg for modifying the image. Going to leave this open till tomorrow and then merge...

removed borders - previous commit image was having grey borders
@epugh epugh merged commit a8719ba into apache:main Nov 24, 2022
epugh pushed a commit that referenced this pull request Nov 24, 2022
* Update search-process.png

changes made to following:-
qt :
previous text :  selects a RequestHandler for a query using /select (by default, the DisMax RequestHandler is used)
changed to : selects a RequestHandler for a query using /select

defType :
previous text :
changed to : selects a query parser for the query if configured for RequestHandler, otherwise by default "Lucene" query parser is used

* Update search-process.png

removed borders - previous commit image was having grey borders
@epugh
Copy link
Contributor

epugh commented Nov 24, 2022

Thanks @AkashTpg for redoing the graphic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments