Lower gradle heap: 3GB is unnecessary (#11936)#1202
Merged
risdenk merged 1 commit intoapache:mainfrom Nov 30, 2022
Merged
Conversation
risdenk
requested review from
HoustonPutman,
cpoerschke,
dsmiley,
epugh,
gerlowskija,
janhoy,
madrob and
magibney
Contributor
Author
|
Anecdotally - this has improved using Gradle in Intellij for builds - the machine doesn't seem to freak out as much with smaller Gradle heap. |
dsmiley
approved these changes
Nov 30, 2022
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
Any impact on build time?
Contributor
Author
|
Not that I've seen - at least not drastically so. I haven't measured it to be honest. I can say that |
risdenk
added a commit
that referenced
this pull request
Nov 30, 2022
Co-authored-by: Robert Muir <rmuir@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports apache/lucene#11936 over to Solr. I've been testing this the past week or so and haven't seen any issues.
You need to clear
gradle.propertiesin the Solr directory and regenerate with./gradlew localSettings(or let the build regenerate it for you next time.