SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

[epugh]

https://issues.apache.org/jira/browse/SOLR-10463

Description

Similar to a number of others, this moves the property to the Builder.

HOWEVER, one thing is that it appears in my searching the source that we do NOT use this property! I'd love to have someone confirm this.. Is there a chance this should actually be deprecated and removed????

Solution

did the migration, however maybe we rip it all out?

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.
• I have added documentation for the Reference Guide

[dsmiley]

You added to the Builder but never consumed it! Do this in CloudSolrClient which is the base of the new & old impls.

You said we do not use this property but I believe you mean we do not set this property. It is used/retrieved in CloudSolrClient.

[epugh]

You added to the Builder but never consumed it! Do this in CloudSolrClient which is the base of the new & old impls.

You said we do not use this property but I believe you mean we do not set this property. It is used/retrieved in CloudSolrClient.

I was about to post a screenshot showing that this value was never used, and finally found it in a method shouldRetry. I duplicated the setting so if you use the builder you get it, if you don't you still get it. Maybe when we remove the deprecated methods, these defaults will just livei n the builder?

[epugh]

@dsmiley @risdenk I think I am ready for another review after addressing feedback. Can I get a LGTM?