Skip to content

SOLR-16602: tweaks to package manager docs to make following along easier#1259

Merged
epugh merged 1 commit intoapache:mainfrom
epugh:SOLR-16602
Jan 4, 2023
Merged

SOLR-16602: tweaks to package manager docs to make following along easier#1259
epugh merged 1 commit intoapache:mainfrom
epugh:SOLR-16602

Conversation

@epugh
Copy link
Contributor

@epugh epugh commented Dec 31, 2022

https://issues.apache.org/jira/browse/SOLR-16602

Description

While trying to understand how PackageManager api works, I went through this page.

Solution

Fix some of the examples and make it easier to use the ref guide "copy" command.

Tests

manually built

@epugh
Copy link
Contributor Author

epugh commented Dec 31, 2022

I removed lots of $ from the bash commands, which solves the copy function, otherwise every copy and paste into a terminal would start with a $ that you have to remove! I wish Antora would just automtically prefix any bash commands in the UI with a $, but not have it in the copy version. Any ideas on how to make that happen @ctargett ??

@epugh epugh requested a review from noblepaul December 31, 2022 13:14
@risdenk
Copy link
Contributor

risdenk commented Jan 4, 2023

I wish Antora would just automtically prefix any bash commands in the UI with a

this isn't necessary. $ is just a terminal prompt display thing. Its not necessary and my terminal doesn't just have $ in the prompt. I'm all for removing the $ to make copy/paste work well.

@epugh
Copy link
Contributor Author

epugh commented Jan 4, 2023

I wish Antora would just automtically prefix any bash commands in the UI with a

this isn't necessary. $ is just a terminal prompt display thing. Its not necessary and my terminal doesn't just have $ in the prompt. I'm all for removing the $ to make copy/paste work well.

Cool, I created https://issues.apache.org/jira/browse/SOLR-16610 to track this.

@epugh epugh merged commit df9a5fe into apache:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants