working and tested changes of solr 9.1#1262
Closed
vatsalpatel3689 wants to merge 1 commit intoapache:mainfrom
vatsalpatel3689:solr_9.1
Closed
working and tested changes of solr 9.1#1262vatsalpatel3689 wants to merge 1 commit intoapache:mainfrom vatsalpatel3689:solr_9.1
vatsalpatel3689 wants to merge 1 commit intoapache:mainfrom
vatsalpatel3689:solr_9.1
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -409,14 +409,14 @@ public static int compare(double a, double b, FacetRequest.SortDirection directi | |||
| if (a < b) return -1; | |||
| if (a > b) return 1; | |||
|
|
|||
| if (Double.isNaN(a)) { | |||
| if (Double.isNaN(b)) { | |||
| if (a != a) { // a==NaN | |||
There was a problem hiding this comment.
💬 2 similar findings have been found in this PR
opt.semgrep.java.lang.correctness.eqeq.eqeq: a == a or a != a is always true. (Unless the value compared is a float or double).
To test if a is not-a-number, use Double.isNaN(a).
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| solr/core/src/java/org/apache/solr/search/facet/FacetModule.java | 413 |
| solr/core/src/java/org/apache/solr/search/facet/FacetModule.java | 419 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-XXXXX
Description
Please provide a short description of the changes you're making with this pull request.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.