Branch 9 1 neo by vatsalpatel3689 · Pull Request #1264 · apache/solr

vatsalpatel3689 · 2023-01-02T22:10:13Z

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
I have created a Jira issue and added the issue ID to my pull request title.
I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
I have developed this patch against the main branch.
I have run ./gradlew check.
I have added tests for my changes.
I have added documentation for the Reference Guide

sonatype-lift · 2023-01-02T22:43:09Z

cluster/scripts/deleteAndReAddNodes.sh

+fi
+
+batchNumber=1
+count=0


SC2034: count appears unused. Verify use (or export if used externally).

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-02T22:43:11Z

cluster/scripts/deleteReplica.sh

+echo "$replica deleted"
+
+currentTimestamp=$(date +%s)
+echo "timeElapsed $(($currentTimestamp-$startTimestamp))"


💬 18 similar findings have been found in this PR

SC2004: $/${} is unnecessary on arithmetic variables.

🔎 Expand here to view all instances of this finding

File Path Line Number

cluster/scripts/deleteReplica.sh 16

cluster/scripts/deleteNodes.sh 18

cluster/scripts/deleteNodes.sh 20

cluster/scripts/deleteNodes.sh 20

cluster/scripts/deleteAndReAddNodes.sh 19

cluster/scripts/deleteAndReAddNodes.sh 19

cluster/scripts/deleteAndReAddNodes.sh 30

cluster/scripts/deleteAndReAddNodes.sh 30

cluster/scripts/deleteAndReAddNodes.sh 31

cluster/scripts/deleteAndReAddNodes.sh 31

Showing 10 of 18 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-02T22:43:13Z

cluster/scripts/deleteNodes.sh

+endpoint=$1
+nodesFileName=$2
+
+IFS=$'\n' read -d '' -r -a nodeIPs < ${nodesFileName}


💬 3 similar findings have been found in this PR

SC2086: Double quote to prevent globbing and word splitting.

🔎 Expand here to view all instances of this finding

File Path Line Number

cluster/scripts/deleteAndReAddNodes.sh 12

cluster/scripts/deleteAndReAddNodes.sh 43

cluster/scripts/deleteAndReAddNodes.sh 60

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-02T23:07:47Z

solr/core/build.gradle

 }

 dependencies {
+  // Spotbugs Annotations are only needed for old findbugs
+  // annotation usage like in Zookeeper during compilation time.
+  // It is not included in the release so exclude from checks.


High Vulnerability:

maven : com.fasterxml.jackson/jackson-bom : 2.13.4.20221013

0 Critical, 1 High, 0 Medium, 0 Low vulnerabilities have been found across 1 dependencies.
View the Lift console for details about these vulnerabilities.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-02T23:07:49Z

solr/core/src/java/org/apache/solr/search/facet/FacetModule.java

    public static int compare(double a, double b, FacetRequest.SortDirection direction) {
      if (a < b) return -1;
      if (a > b) return 1;

-      if (a != a) {  // a==NaN
+      if (a != a) { // a==NaN


💬 2 similar findings have been found in this PR

opt.semgrep.java.lang.correctness.eqeq.eqeq: a == a or a != a is always true. (Unless the value compared is a float or double).
To test if a is not-a-number, use Double.isNaN(a).

🔎 Expand here to view all instances of this finding

File Path Line Number

solr/core/src/java/org/apache/solr/search/facet/FacetModule.java 413

solr/core/src/java/org/apache/solr/search/facet/FacetModule.java 419

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

fkltr changes

b3a99f3

vatsalpatel3689 changed the base branch from main to branch_9_1 January 2, 2023 22:12

vatsalpatel3689 changed the base branch from branch_9_1 to main January 2, 2023 22:15

vatsalpatel3689 changed the base branch from main to branch_9_1 January 2, 2023 22:15

fixing issue

ad0bcec

vatsalpatel3689 changed the base branch from branch_9_1 to main January 2, 2023 22:41

sonatype-lift bot reviewed Jan 2, 2023

View reviewed changes

vatsalpatel3689 changed the base branch from main to branch_9_1 January 3, 2023 05:23

vatsalpatel3689 closed this by deleting the head repository Jan 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Branch 9 1 neo#1264

Branch 9 1 neo#1264
vatsalpatel3689 wants to merge 2 commits intoapache:branch_9_1from
vatsalpatel3689:branch_9_1_neo

vatsalpatel3689 commented Jan 2, 2023

Uh oh!

sonatype-lift bot Jan 2, 2023

Uh oh!

sonatype-lift bot Jan 2, 2023

Uh oh!

sonatype-lift bot Jan 2, 2023

Uh oh!

sonatype-lift bot Jan 2, 2023

Uh oh!

sonatype-lift bot Jan 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Conversation

vatsalpatel3689 commented Jan 2, 2023

Description

Solution

Tests

Checklist

Uh oh!

sonatype-lift bot Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 2, 2023

Choose a reason for hiding this comment

maven : com.fasterxml.jackson/jackson-bom : 2.13.4.20221013

Uh oh!

sonatype-lift bot Jan 2, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant